chore: remove stale GitHub Pages CNAME file#645
Conversation
Deployment moved to Netlify, which manages the custom domain via DNS. The CNAME file only affects gh-pages deployments, which stopped in April 2024, and it currently ships as a dead file on the production site. Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mesutoezdil The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for project-hami ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughCustom-domain guidance now reflects Netlify-managed DNS. The ChangesCustom domain handling
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Removes the legacy GitHub Pages static/CNAME artifact from the Docusaurus site output and updates repository agent documentation to reflect that the custom domain is handled via Netlify/DNS rather than a GitHub Pages CNAME file.
Changes:
- Delete
static/CNAMEso it no longer ships as a dead artifact in production builds. - Update
AGENTS.mdto remove/replace references tostatic/CNAMEas the custom domain mechanism.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| static/CNAME | Removed the unused GitHub Pages CNAME artifact from the site output. |
| AGENTS.md | Updated documentation to remove references to the deleted CNAME file and clarify hosting/domain setup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What
static/CNAME, a GitHub Pages artifactAGENTS.mdWhy
The site deploys through Netlify, which manages the
project-hami.iodomain via DNS. ACNAMEfile only has an effect when a site is deployed to GitHub Pages from thegh-pagesbranch, and that branch has not been updated since April 2024. Today the file just ships as a dead artifact atproject-hami.io/CNAMEon every deploy.Related: the stale GitHub Pages mirror itself (still live at project-hami.github.io/website with 2024 content) needs an admin to disable Pages in repo settings, tracked in #627.
Summary by CodeRabbit
Documentation
Chores