feat: TalkTool speaking guard + FishTTS done_speaking signal#148
Merged
Conversation
xingjianll
commented
Apr 5, 2026
xingjianll
commented
Contributor
- FishTTS: restructured to one websocket call per utterance, sends done_speaking signal after real audio duration has elapsed (not generation time). Uses PCM sample count to calculate exact playback duration.
- TalkTool: tracks speaking state, rejects new talk calls with error while still speaking. Clears on done_speaking signal from TTS.
- Both done_speaking sender/receiver are optional for backward compat.
- FishTTS: restructured to one websocket call per utterance, sends done_speaking signal after real audio duration has elapsed (not generation time). Uses PCM sample count to calculate exact playback duration. - TalkTool: tracks speaking state, rejects new talk calls with error while still speaking. Clears on done_speaking signal from TTS. - Both done_speaking sender/receiver are optional for backward compat. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Test Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.