Skip to content

Add optional disabled campaign penalty for create matcher#534

Open
minyanyi wants to merge 1 commit into
Project60:masterfrom
minyanyi:feat/disabled-campaign-penalty
Open

Add optional disabled campaign penalty for create matcher#534
minyanyi wants to merge 1 commit into
Project60:masterfrom
minyanyi:feat/disabled-campaign-penalty

Conversation

@minyanyi
Copy link
Copy Markdown

Refs #133

Summary

  • add an optional disabled_campaign_penalty config value for the create campaign matcher
  • reduce the suggestion score when the matched campaign is disabled and surface that penalty in the suggestion warning
  • add a regression test that covers the reduced-score behavior for disabled campaigns

Testing

  • could not run PHPUnit locally on this machine because php and cv are not available in PATH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant