IntakeExtension cleanups#100
Open
kcooney wants to merge 1 commit into
Open
Conversation
kcooney
force-pushed
the
kcooney/intake
branch
8 times, most recently
from
bbc5cbe to
630048e
Compare
kcooney
force-pushed
the
kcooney/simulation-class
branch
from
3a85145 to
16d9805
Compare
kcooney
changed the base branch from
kcooney/simulation-class
to
kcooney/intake-resolve-todo
kcooney
force-pushed
the
kcooney/intake-resolve-todo
branch
from
139c389 to
09c5da3
Compare
kcooney
force-pushed
the
kcooney/simulation-class
branch
from
3a78c0b to
6f42251
Compare
kcooney
force-pushed
the
kcooney/simulation-class
branch
from
6f42251 to
ddd1f36
Compare
kcooney
force-pushed
the
kcooney/intake
branch
2 times, most recently
from
6835a41 to
2e9e375
Compare
kcooney
force-pushed
the
kcooney/simulation-class
branch
from
ddd1f36 to
ac1d86d
Compare
kcooney
force-pushed
the
kcooney/simulation-class
branch
from
ac1d86d to
18eb6bb
Compare
- Refactor `IntakeExtensionIOSim` to delegate to `IntakeExtensionIOReal` - To ensure the above change is safe, remove default implementations in `IntakeExtensionIO` - Created `IntakeExtensionIOStub` (for use in replay mode) - Create `Simulation` class - move `SIM_TIME_PERIOD` to this class - extract `getMotorSupplyVoltage()` and add it to `Simulation` - Refactor `IntakeExtensionConstants.toMotorSetpoint()` to `ExtenderPositions.getAngle()` - Merge tests in `IntakeExtensionTest` using `assertAll()`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these changes, the
IntakeExtensionIOSimexercises more of the "real"code.
IntakeExtensionIOSimto delegate toIntakeExtensionIORealIntakeExtensionIOIntakeExtensionIOStub(for use in replay mode)IntakeExtensionTestusingassertAll()