fix(lint): resolve max-lines errors by extracting conflict detection helper

- create-project.ts: extract detectDockerIdentityConflicts to reduce function size;
  add ConflictingProjectEntry type alias to avoid inline type expansion
- docker.ts: revert linter auto-formatting of import to keep line count stable

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: konard

packages/app/src/lib/shell/docker.ts

@@ -5,12 +5,7 @@ import { ExitCode } from "@effect/platform/CommandExecutor"
 import type { PlatformError } from "@effect/platform/Error"
 import { Duration, Effect, pipe, Schedule } from "effect"
 
-import {
-  runCommandCapture,
-  runCommandExitCode,
-  runCommandWithCapturedOutput,
-  runCommandWithExitCodes
-} from "./command-runner.js"
+import { runCommandCapture, runCommandExitCode, runCommandWithCapturedOutput, runCommandWithExitCodes } from "./command-runner.js"
 import { composeSpec, resolveDockerComposeEnv } from "./docker-compose-env.js"
 import { parseInspectNetworkEntry } from "./docker-inspect-parse.js"
 import { CommandFailedError, DockerCommandError } from "./errors.js"

packages/app/src/lib/usecases/actions/create-project.ts

@@ -257,6 +257,8 @@ const resolveRuntimeConfig = (
 
 type DockerIdentityOwner = Pick<TemplateConfig, "containerName" | "serviceName" | "volumeName" | "enableMcpPlaywright">
 
+type ConflictingProjectEntry = { readonly projectDir: string; readonly repoUrl: string; readonly containerName: string; readonly serviceName: string }
+
 type DockerIdentityNamespace = "container" | "composeProject" | "volume"
 
 type DockerIdentityClaim = Omit<DockerIdentityConflict, "conflictingProjectDir"> & {
@@ -267,103 +269,63 @@ const resolveDockerIdentityClaims = (
   config: DockerIdentityOwner
 ): ReadonlyArray<DockerIdentityClaim> => [
   { namespace: "container", kind: "containerName", name: config.containerName },
-  ...(config.enableMcpPlaywright
-    ? [
-      {
-        namespace: "container",
-        kind: "browserContainerName",
-        name: `${config.containerName}-browser`
-      } satisfies DockerIdentityClaim
-    ]
-    : []),
+  ...(config.enableMcpPlaywright ? [
+    { namespace: "container", kind: "browserContainerName", name: `${config.containerName}-browser` } satisfies DockerIdentityClaim
+  ] : []),
   { namespace: "composeProject", kind: "serviceName", name: resolveComposeProjectName(config) },
   { namespace: "volume", kind: "volumeName", name: config.volumeName },
-  ...(config.enableMcpPlaywright
-    ? [
-      {
-        namespace: "volume",
-        kind: "browserVolumeName",
-        name: `${config.volumeName}-browser`
-      } satisfies DockerIdentityClaim
-    ]
-    : []),
+  ...(config.enableMcpPlaywright ? [
+    { namespace: "volume", kind: "browserVolumeName", name: `${config.volumeName}-browser` } satisfies DockerIdentityClaim
+  ] : []),
   { namespace: "volume", kind: "bootstrapVolumeName", name: resolveProjectBootstrapVolumeName(config) }
 ]
 
-const deleteConflictingProjectsIfNeeded = (
+const detectDockerIdentityConflicts = (
   resolvedOutDir: string,
   config: DockerIdentityOwner,
-  force: boolean
-): Effect.Effect<void, DockerIdentityConflictError | PlatformError | DockerCommandError, CreateProjectRuntime> =>
+  configPaths: ReadonlyArray<string>
+): Effect.Effect<
+  { readonly conflicts: ReadonlyArray<DockerIdentityConflict>; readonly projects: Map<string, ConflictingProjectEntry> },
+  PlatformError, CreateProjectRuntime
+> =>
   Effect.gen(function*(_) {
-    const index = yield* _(loadProjectIndex())
-    if (index === null) {
-      return
-    }
-
     const candidateClaims = resolveDockerIdentityClaims(config)
     const conflicts: Array<DockerIdentityConflict> = []
-    const conflictingProjects = new Map<
-      string,
-      {
-        readonly projectDir: string
-        readonly repoUrl: string
-        readonly containerName: string
-        readonly serviceName: string
-      }
-    >()
-
-    for (const configPath of index.configPaths) {
-      const status = yield* _(
-        loadProjectStatus(configPath).pipe(
-          Effect.match({
-            onFailure: () => null,
-            onSuccess: (value) => value
-          })
-        )
-      )
-      if (status === null || status.projectDir === resolvedOutDir) {
-        continue
-      }
-
+    const projects = new Map<string, ConflictingProjectEntry>()
+    for (const configPath of configPaths) {
+      const status = yield* _(loadProjectStatus(configPath).pipe(Effect.match({ onFailure: () => null, onSuccess: (v) => v })))
+      if (status === null || status.projectDir === resolvedOutDir) { continue }
       const existingClaims = resolveDockerIdentityClaims(status.config.template)
       const sharedClaims = candidateClaims.flatMap((candidate) =>
-        existingClaims.some(
-            (existing) => existing.namespace === candidate.namespace && existing.name === candidate.name
-          )
+        existingClaims.some((e) => e.namespace === candidate.namespace && e.name === candidate.name)
           ? [{ conflictingProjectDir: status.projectDir, kind: candidate.kind, name: candidate.name }]
           : []
       )
-
-      if (sharedClaims.length === 0) {
-        continue
-      }
-
-      for (const claim of sharedClaims) {
-        conflicts.push(claim)
-      }
-      conflictingProjects.set(status.projectDir, {
-        projectDir: status.projectDir,
-        repoUrl: status.config.template.repoUrl,
-        containerName: status.config.template.containerName,
-        serviceName: status.config.template.serviceName
+      if (sharedClaims.length === 0) { continue }
+      for (const claim of sharedClaims) { conflicts.push(claim) }
+      projects.set(status.projectDir, {
+        projectDir: status.projectDir, repoUrl: status.config.template.repoUrl,
+        containerName: status.config.template.containerName, serviceName: status.config.template.serviceName
       })
     }
+    return { conflicts, projects }
+  })
 
-    if (conflicts.length === 0) {
-      return
-    }
-
+const deleteConflictingProjectsIfNeeded = (
+  resolvedOutDir: string,
+  config: DockerIdentityOwner,
+  force: boolean
+): Effect.Effect<void, DockerIdentityConflictError | PlatformError | DockerCommandError, CreateProjectRuntime> =>
+  Effect.gen(function*(_) {
+    const index = yield* _(loadProjectIndex())
+    if (index === null) { return }
+    const { conflicts, projects } = yield* _(detectDockerIdentityConflicts(resolvedOutDir, config, index.configPaths))
+    if (conflicts.length === 0) { return }
     if (!force) {
       return yield* _(Effect.fail(new DockerIdentityConflictError({ projectDir: resolvedOutDir, conflicts })))
     }
-
-    for (const conflictingProject of conflictingProjects.values()) {
-      yield* _(
-        Effect.logWarning(
-          `Force enabled: replacing conflicting docker-git project ${conflictingProject.projectDir}`
-        )
-      )
+    for (const conflictingProject of projects.values()) {
+      yield* _(Effect.logWarning(`Force enabled: replacing conflicting docker-git project ${conflictingProject.projectDir}`))
       yield* _(deleteDockerGitProject(conflictingProject))
     }
   })