Make plugin updates compatibility-safe - #37
Open
lyrishark wants to merge 3 commits into
Open
Conversation
Author
|
Live 0.10 verification is complete and this is ready for maintainer review. Additional proof since the draft opened:
The first public monorepo addon release is here: https://github.com/lyrishark/community-addons/releases/tag/psycheros-htf-music-listener-v0.2.0 |
lyrishark
marked this pull request as ready for review
July 24, 2026 13:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The plugin manager currently assumes every Git plugin lives at the repository root and treats the highest matching tag as the update. That makes monorepo addons awkward to install and can offer or apply a release that does not support the running Psycheros version. The apply route also accepts repository details from the browser instead of re-reading the installed plugin's declared update channel.
What changed
update.packagePathmetadata for plugins stored in a repository subdirectoryplugin.jsonand choose the newest release compatible with the running Psycheros and Entity Core versionsVerification
deno test -A packages/plugin-api/tests/manifest_test.ts packages/psycheros/tests/updater_test.ts packages/psycheros/tests/plugin_installer_test.ts— 26 passeddeno test -A --quiet packages/psycheros/tests packages/plugin-api/tests— 156 passeddeno linton all touched TypeScript files — passeddeno checkon the updater and plugin-manager routes — passeddeno fmt --checkon all applicable touched files — passedaddons/live-smokev1.0.0The full workspace test task reports 163 passes and 8 Windows cleanup failures in
packages/entity-core/tests/runner_test.ts(os error 32while removing temporary database directories). The same failure reproduces on pristine upstreammain, so it is not introduced by this branch. Repository-widefmt:checkalso reports pre-existing formatting differences in unrelated launcher and Entity Loom files; all files changed here pass their targeted format check.Draft for maintainer review before we convert and publish the first monorepo addon releases against this contract.