GPS time correlation on log file parsing#71
Draft
LelsersLasers wants to merge 20 commits into
Draft
Conversation
table not updated yet
Contributor
There was a problem hiding this comment.
Pull request overview
Adds GPS-based time correlation to DAQ log parsing so parsed CSV outputs can include a “real” timestamp derived from GPS time messages, and correlated chunks can be named with the time of the first message.
Changes:
- Introduces a
daq_log_parse::correlatemodule that extractsgps_timemessages per chunk and fits a linear regression between DAQ ms and Unix ms. - Updates the log parsing UI flow to run correlation after chunking and pass correlated chunks into CSV generation.
- Extends CSV output to include a correlated time column and optionally suffixes output filenames with the first correlated timestamp.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/ui/log_parser.rs | Runs chunk time-correlation before writing CSV tables. |
| src/daq_log_parse/table.rs | Accepts correlated chunks, adds correlated time column, and names output files with correlated first time when available. |
| src/daq_log_parse/mod.rs | Exposes the new correlate module. |
| src/daq_log_parse/correlate.rs | Implements GPS timestamp extraction and linear regression correlation per chunk. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
timestamps not folded under the row headers
Member
Author
|
Currently gives weird results: DAQ ticks are 1 ms so the slope should be exactly 1 and the RMS is very high, but from debug printing the algorithm is working correctly, it is the data itself that is noisy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


out_###_TimeOfFirstMessage