Declare Apple platform requirements and fix AndroidManifest dependency#4
Open
colemancda wants to merge 2 commits into
Open
Declare Apple platform requirements and fix AndroidManifest dependency#4colemancda wants to merge 2 commits into
colemancda wants to merge 2 commits into
Conversation
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two manifest fixes found while building a downstream app (BluetoothExplorer) that depends on this
package.
Declare Apple platform requirements
The package declared only
.macOS(.v15). SwiftPM defaults unspecified platforms to iOS 12, whileBluetooth,BluetoothGAPandGATTrequire iOS 13 — so any Apple-platform resolve of a graphcontaining this package failed:
Now declares
.iOS(.v13), .watchOS(.v6), .tvOS(.v13)to match. This package only ever builds forAndroid, but SwiftPM validates platform requirements across the whole graph regardless of
.when(platforms:)conditions on the usage, so the declaration has to be present.Source
AndroidManifestfrom swift-android-nativeAndroidManifestmoved out of PureSwift/Android intoswift-android-native(Android PR #40), butthis package still requested it from
Android:The other four products it takes from
Android(AndroidOS,AndroidContent,AndroidUtil,AndroidApp) are unaffected; onlyAndroidManifestmoved. It now depends onswift-android-nativedirectly, using the same fork and branch that PureSwift/Android andskip-android-bridge use so the package identity does not conflict.
Note: depends on MillerTechnologyPeru/swift-android-native#… (merging current upstream
maininto
feature/pureswift), because that branch did not yet exportAndroidManifest. Merge thatfirst.