feat: Adds request timeout handling for table data endpoints#636
Open
likp wants to merge 12 commits into
Open
Conversation
Introduced a `RequestTimeout` attribute to `GetTableData` and `GetTableDataByPost` methods to enforce a timeout policy. Integrated `RequestTimeouts` middleware in the application pipeline and ensured it is applied selectively to relevant requests.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
likp
changed the title
…ince it can be used maliciously
Introduced `CancellationToken` support in `DataWorkflow` to enable cancellation of long-running operations. Updated the `IDataWorkflow` interface to include `CancellationToken` parameters in method signatures.
Introduced `CancellationAwareDataWorkflow` to simulate workflows with cancellation token support. Updated `SavedQueryApiControllerTests` and `TableApiControllerTest` to use this implementation, replacing existing `IDataWorkflow` services. Configured `RequestTimeoutOptions` in tests to define timeout policies for `GetTableDataTimeout`. Adjusted timeout values to 1ms and 50ms in respective tests. Added `[DoNotParallelize]` to `Cancelling_request_should_return_timeout` to ensure sequential execution. Verified HTTP 504 Gateway Timeout status for canceled requests.
…set to 40 seconds.
|
likp
marked this pull request as ready for review
July 14, 2026 14:10
likp
requested review from
JohannesFinsveen,
MikaelNordberg,
oyessb and
runejo
as code owners
July 14, 2026 14:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced a
RequestTimeoutattribute toGetTableDataandGetTableDataByPostmethods to enforce a timeoutpolicy. Integrated
RequestTimeoutsmiddleware in the application pipeline and ensured it is applied selectively to relevant requests.