Add BatchLoader + BatchTask for batched file loading#68
Merged
Conversation
Sources can now wrap a loader function in BatchLoader(loader_fn, batch_size) and share the instance across DatasetResources that should be batched together. Ingestify groups those resources, chunks them into groups of batch_size, wraps each chunk in a BatchTask, and calls the loader_fn once per batch with lists of file_resources / current_files / dataset_resources. load_file() now passes dataset_resource to loaders that accept it (signature introspection with lru_cache, so existing loaders continue to work without changes).
Different BatchTasks sharing the same loader write/read different keys (id(file_resource)); CPython dict operations on distinct keys are atomic under the GIL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sources can now wrap a loader function in BatchLoader(loader_fn, batch_size) and share the instance across DatasetResources that should be batched together. Ingestify groups those resources, chunks them into groups of batch_size, wraps each chunk in a BatchTask, and calls the loader_fn once per batch with lists of file_resources / current_files / dataset_resources.
load_file() now passes dataset_resource to loaders that accept it (signature introspection with lru_cache, so existing loaders continue to work without changes).