feat: Add support for Guild Scheduled Event Recurrence#2749
feat: Add support for Guild Scheduled Event Recurrence#2749DA-344 wants to merge 25 commits intoPycord-Development:masterfrom
Conversation
Co-authored-by: plun1331 <plun1331@gmail.com> Signed-off-by: DA344 <108473820+DA-344@users.noreply.github.com>
… into feat/recurrence-rule
| If this recurrence rule was obtained from the API you will need to | ||
| :meth:`.copy` it in order to edit it. |
There was a problem hiding this comment.
This class seems to serve more as a dataclass-ish than an API object. Which is fine, but having an edit method here, and then disallowing editing attributes seems weird. This class should realistically not even hold self._state (I believe). It would probably make everything easier.
|
Merge conflicts |
b55c125 to
82659b2
Compare
… into feat/recurrence-rule
|
|
||
| .. attribute:: monday | ||
|
|
||
| Monday, the first day of the week. Index of 0. |
There was a problem hiding this comment.
Not to get political, the first day of the week is not internationally recognized as Monday. Personally, I think we can just drop "the [x] day of the week" from the documentation, as a reasonable individual should know what a Monday is.
There was a problem hiding this comment.
yeah that makes sense, will do.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com> Signed-off-by: DA344 <108473820+DA-344@users.noreply.github.com>
Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com> Signed-off-by: DA344 <108473820+DA-344@users.noreply.github.com>
|
|
||
| - Added recurrence rules for `ScheduledEvent` objects. | ||
| ([#2749](https://github.com/Pycord-Development/pycord/pull/2749)) | ||
|
|
There was a problem hiding this comment.
| - Added recurrence rules for `ScheduledEvent` objects. | |
| ([#2749](https://github.com/Pycord-Development/pycord/pull/2749)) | |
| - Added recurrence rules for guild scheduled events. | |
| ([#2749](https://github.com/Pycord-Development/pycord/pull/2749)) | |
25347b5 to
cc6ebbb
Compare
45025bd to
01e9fa8
Compare
Summary
Adds support for receiving, setting, and updating a Scheduled Event's recurrence rule.
Documentation: resources/guild-scheduled-event
Needs testing.
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.