Skip to content

feat: Add support for Guild Scheduled Event Recurrence#2749

Open
DA-344 wants to merge 25 commits intoPycord-Development:masterfrom
DA-344:feat/recurrence-rule
Open

feat: Add support for Guild Scheduled Event Recurrence#2749
DA-344 wants to merge 25 commits intoPycord-Development:masterfrom
DA-344:feat/recurrence-rule

Conversation

@DA-344
Copy link
Copy Markdown
Contributor

@DA-344 DA-344 commented Mar 23, 2025

Summary

Adds support for receiving, setting, and updating a Scheduled Event's recurrence rule.

Documentation: resources/guild-scheduled-event

Needs testing.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

Comment thread discord/scheduled_events.py
Comment thread discord/scheduled_events.py
Comment thread discord/scheduled_events.py Outdated
Comment thread discord/scheduled_events.py Outdated
Comment thread discord/scheduled_events.py Outdated
Comment thread discord/scheduled_events.py Outdated
DA-344 and others added 3 commits April 1, 2025 09:53
Co-authored-by: plun1331 <plun1331@gmail.com>
Signed-off-by: DA344 <108473820+DA-344@users.noreply.github.com>
Comment thread discord/scheduled_events.py Outdated
Comment thread discord/scheduled_events.py Outdated
Comment on lines +321 to +322
If this recurrence rule was obtained from the API you will need to
:meth:`.copy` it in order to edit it.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more question... why?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class seems to serve more as a dataclass-ish than an API object. Which is fine, but having an edit method here, and then disallowing editing attributes seems weird. This class should realistically not even hold self._state (I believe). It would probably make everything easier.

@Lulalaby
Copy link
Copy Markdown
Member

Lulalaby commented Aug 2, 2025

Merge conflicts
(complicated discord feature, requires intense testing)

@Paillat-dev Paillat-dev added API reflection Discord API isn't correctly reflected hold: testing This pull request requires further testing labels Aug 6, 2025
@Lulalaby Lulalaby requested a review from a team as a code owner August 30, 2025 20:33
@Lulalaby Lulalaby force-pushed the master branch 2 times, most recently from b55c125 to 82659b2 Compare August 30, 2025 21:10
@Lulalaby Lulalaby removed the on hold label Aug 30, 2025
@Lulalaby Lulalaby requested a review from a team as a code owner September 1, 2025 12:31
@Paillat-dev Paillat-dev self-assigned this Sep 1, 2025
@Paillat-dev Paillat-dev self-requested a review September 1, 2025 15:41
Comment thread docs/api/enums.rst Outdated
Comment thread discord/enums.py
Comment thread docs/api/enums.rst Outdated
Comment thread docs/api/enums.rst Outdated

.. attribute:: monday

Monday, the first day of the week. Index of 0.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to get political, the first day of the week is not internationally recognized as Monday. Personally, I think we can just drop "the [x] day of the week" from the documentation, as a reasonable individual should know what a Monday is.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that makes sense, will do.

Comment thread CHANGELOG.md Outdated
@Lumabots

This comment was marked as resolved.

@Paillat-dev
Copy link
Copy Markdown
Member

As I already mentioned somewhere (forgot where) this PR should focus on Event Recurrence, and #3025 should focus on fixing the caching and parsing issues currently present.

@DA-344 Are you still planning to work on this ? There's a couple comments to be addressed.

DA-344 and others added 6 commits January 19, 2026 20:05
Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com>
Signed-off-by: DA344 <108473820+DA-344@users.noreply.github.com>
Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com>
Signed-off-by: DA344 <108473820+DA-344@users.noreply.github.com>
Comment thread discord/enums.py
Comment thread CHANGELOG.md
Comment on lines 17 to +20

- Added recurrence rules for `ScheduledEvent` objects.
([#2749](https://github.com/Pycord-Development/pycord/pull/2749))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Added recurrence rules for `ScheduledEvent` objects.
([#2749](https://github.com/Pycord-Development/pycord/pull/2749))
- Added recurrence rules for guild scheduled events.
([#2749](https://github.com/Pycord-Development/pycord/pull/2749))

@Paillat-dev Paillat-dev requested a review from plun1331 February 13, 2026 13:02
@Paillat-dev Paillat-dev added priority: low Low Priority and removed priority: medium Medium Priority labels Mar 4, 2026
@Paillat-dev Paillat-dev removed this from the v2.8.0rc.1 milestone Mar 4, 2026
@Lulalaby Lulalaby added this to Pycord Mar 18, 2026
@github-project-automation github-project-automation bot moved this to Todo in Pycord Mar 18, 2026
@Paillat-dev Paillat-dev requested review from a team March 24, 2026 10:22
@Lulalaby Lulalaby force-pushed the master branch 3 times, most recently from 25347b5 to cc6ebbb Compare April 14, 2026 09:00
@Paillat-dev Paillat-dev force-pushed the master branch 2 times, most recently from 45025bd to 01e9fa8 Compare April 14, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API reflection Discord API isn't correctly reflected hold: testing This pull request requires further testing priority: low Low Priority

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

9 participants