fix: align protobuf runtime constraint with checked-in B01 gencode#803
Merged
allenporter merged 4 commits intoPython-roborock:mainfrom Apr 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the project’s protobuf runtime dependency range so it matches the checked-in generated protobuf module’s runtime version validation behavior, and updates the lockfile accordingly to prevent installation-time/import-time mismatches.
Changes:
- Update
pyproject.tomldependency constraint fromprotobuf>=5,<7toprotobuf>=6,<7. - Update
uv.lockto reflect the new protobuf constraint in the project metadata.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Tightens the declared protobuf runtime dependency range. |
| uv.lock | Syncs locked metadata to match the updated protobuf constraint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
allenporter
requested changes
Apr 1, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
allenporter
approved these changes
Apr 5, 2026
Contributor
|
I applied co-pilots suggestion and manually fixed uv to have the same fix. Thanks for making this change, just wanted to merge this so we can set the right versions asap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
protobuf>=5,<7toprotobuf>=6,<7uv.lockin sync with the new constraintWhy
The checked-in
roborock/map/proto/b01_scmap_pb2.pywas generated by protobuf Python 6.x and performs runtime major-version validation. Allowing protobuf 5 at runtime can fail import/version checks, so the dependency range should match the checked-in gencode.Validation
uv lockruff format --check . && ruff check .uv run pytest --log-cli-level=DEBUG -vv -s --cov --cov-branch --cov-report=xml