Skip to content

fix: align protobuf runtime constraint with checked-in B01 gencode#803

Merged
allenporter merged 4 commits intoPython-roborock:mainfrom
arduano:leo/pr785-followup-protobuf-runtime
Apr 5, 2026
Merged

fix: align protobuf runtime constraint with checked-in B01 gencode#803
allenporter merged 4 commits intoPython-roborock:mainfrom
arduano:leo/pr785-followup-protobuf-runtime

Conversation

@arduano
Copy link
Copy Markdown
Contributor

@arduano arduano commented Apr 1, 2026

Summary

  • tighten the runtime dependency from protobuf>=5,<7 to protobuf>=6,<7
  • keep uv.lock in sync with the new constraint
  • keep the checked-in proto header limited to regeneration instructions only

Why

The checked-in roborock/map/proto/b01_scmap_pb2.py was generated by protobuf Python 6.x and performs runtime major-version validation. Allowing protobuf 5 at runtime can fail import/version checks, so the dependency range should match the checked-in gencode.

Validation

  • uv lock
  • ruff format --check . && ruff check .
  • uv run pytest --log-cli-level=DEBUG -vv -s --cov --cov-branch --cov-report=xml

Copilot AI review requested due to automatic review settings April 1, 2026 01:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens the project’s protobuf runtime dependency range so it matches the checked-in generated protobuf module’s runtime version validation behavior, and updates the lockfile accordingly to prevent installation-time/import-time mismatches.

Changes:

  • Update pyproject.toml dependency constraint from protobuf>=5,<7 to protobuf>=6,<7.
  • Update uv.lock to reflect the new protobuf constraint in the project metadata.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
pyproject.toml Tightens the declared protobuf runtime dependency range.
uv.lock Syncs locked metadata to match the updated protobuf constraint.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

allenporter and others added 2 commits April 5, 2026 07:06
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@allenporter allenporter merged commit 6d5cfb8 into Python-roborock:main Apr 5, 2026
7 checks passed
@allenporter
Copy link
Copy Markdown
Contributor

I applied co-pilots suggestion and manually fixed uv to have the same fix. Thanks for making this change, just wanted to merge this so we can set the right versions asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants