Skip to content

Add additional test data devices types for Saros 10, PearlS Lite, and Q5 Max+.#807

Open
allenporter wants to merge 5 commits intoPython-roborock:mainfrom
allenporter:saros-10-device-type
Open

Add additional test data devices types for Saros 10, PearlS Lite, and Q5 Max+.#807
allenporter wants to merge 5 commits intoPython-roborock:mainfrom
allenporter:saros-10-device-type

Conversation

@allenporter
Copy link
Copy Markdown
Contributor

This adds additional device and product information from end user diagnostics and update the snapshots that output the supported trait fields. This also adds a snapshot test for all supported features across all device/product types.

Copilot AI review requested due to automatic review settings April 5, 2026 15:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds new home-data test fixtures for additional Roborock device/product variants (Saros 10 / model a147 and PearlS Lite / model a123) and expands snapshot-based testing to assert decoded DeviceFeatures across all available testdata device/product pairs.

Changes:

  • Added new home_data_product_*.json and home_data_device_*.json fixtures for Saros 10 (a147) and PearlS Lite (a123).
  • Extended tests/mock_data.py to build DEVICE_PRODUCT_PAIRS by joining device fixtures to product fixtures via productId.
  • Added a parametrized snapshot test that constructs DeviceFeatures from home-data feature flags for every fixture pair, and updated snapshot outputs.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/testdata/home_data_product_a147.json Adds product schema fixture for Saros 10 (a147).
tests/testdata/home_data_product_a123.json Adds product schema fixture for PearlS Lite (a123).
tests/testdata/home_data_device_saros.json Adds device fixture for Saros 10 using featureSet/newFeatureSet.
tests/testdata/home_data_device_a123.json Adds device fixture for PearlS Lite using featureSet/newFeatureSet.
tests/test_supported_features.py Adds parametrized snapshot test over all fixture device/product pairs.
tests/mock_data.py Adds typed device/product parsing and builds DEVICE_PRODUCT_PAIRS; renames S7 fixture constant.
tests/devices/traits/v1/snapshots/test_device_features.ambr Updates trait snapshot outputs to include new fixtures.
tests/snapshots/test_supported_features.ambr Adds snapshots for the new cross-device DeviceFeatures test.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@allenporter allenporter changed the title Add additional test data devices types for Saros 10 and PearlS Lite. Add additional test data devices types for Saros 10, PearlS Lite, and Q5 Max+. Apr 5, 2026
@Lash-L
Copy link
Copy Markdown
Collaborator

Lash-L commented Apr 6, 2026

Want to update https://github.com/Python-roborock/python-roborock/blob/main/SUPPORTED_FEATURES.md as well? The script should be able to take from diagnostics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants