Roundtrip test and some fixes to inconsistencies between the schema, examples, and JSONMetadataHandler#99
Roundtrip test and some fixes to inconsistencies between the schema, examples, and JSONMetadataHandler#99fedorov wants to merge 0 commit intoQIICR:masterfrom
Conversation
| ) | ||
|
|
||
| add_test(NAME seg_meta_roundtrip | ||
| COMMAND python ${CMAKE_SOURCE_DIR}/util/comparejson.py |
There was a problem hiding this comment.
@fedorov The test is failing, because this python file does not exist. Its name is jsoncompare.py
|
@fedorov I suggest, that you first merge my PR after it passed all tests and then I will merge your changes because there will be conflicts.... |
|
@fedorov Actually I can just create a new PR with a combination of those two because I already rebased your branch to mine. What do you think? |
|
sure, that is fine. I didn't look carefully into why the test fails, because I expected it to fail. |
|
Why did you expect it to fail? |
|
Because not all of the attributes were populated on read, when I looked at the json converter produces. Also, comparejson is a separate file I didn't commit. I added it now. I agree naming can be improved to be less confusing. |
|
@fedorov Can you force push your commits again. Somehow your commits disappeared after I pushed to your github (which actually should not be allowed) |
done, sorry, overwhelmed by emails... No idea how it was possible for you to alter a repository under my account, you are not even listed as a collaborator under fedorov/dcmqi! |
2 participants
Followup on #97.
jsoncompare is from https://github.com/ChannelIQ/jsoncompare, with ChannelIQ/jsoncompare#8 applied.