[CQT-450] Update libQASM#311
Open
elenbaasc wants to merge 6 commits into
Open
Conversation
rares1609
approved these changes
May 11, 2026
rares1609
left a comment
rares1609
left a comment
There was a problem hiding this comment.
This looks good to me. The mentioned two-qubit gates and measure instructions are implemented, with the latter being tested too.
The one thing which sprang to mind was that maybe tests should be made for the two-qubit gates too? At the same time, I looked a bit and at first glance I did not see tests for other gates, so maybe this is done on purpose. To this end I will leave it approved, as is. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the following two-qubit gates:
CYSqrtSWAPInvSqrtSWAPISWAPSqrtISWAPMSDCNOTCVMECRAdded the following measure instruction variants (and tests for these variants):
measureXmeasureYmeasureZ