Repository navigation
fix: treat null CBS metadata fields as empty strings - #3
Merged
Merged
Conversation
CBS sends explicit nulls (e.g. "Description": null in 86103NED), so .get(key, "") returned None and pydantic rejected it, crashing get_metadata(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CBS returns explicit
nullfor missing metadata fields..get(key, "")only applies its default when the key is absent, so it passedNonethrough and pydantic rejected it. As a result,get_metadata("86103NED")crashed.The same change applies to every string field of
ColumnandTableMetadata.Evidence
Client().get_metadata("86103NED")raisesValidationError: description — Input should be a valid string [input_value=None].After: it returns 40 properties.
TestGetMetadata::test_null_fields_become_empty_strings: fails onmainwith the sameValidationErrorand passes on this branch.ruff check,ruff format --checkandty checkare clean.Merge Danger
Door: two-way
Blast Radius: small
Only the null-handling changes. A field that used to crash is now
"".idfalls back to the requested table ID whenIdentifieris null.🤖 Generated with Claude Code