Skip to content

[codex] Apply audit remediation#114

Merged
Pigbibi merged 1 commit into
mainfrom
codex/report-remediation-20260610
Jun 10, 2026
Merged

[codex] Apply audit remediation#114
Pigbibi merged 1 commit into
mainfrom
codex/report-remediation-20260610

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • apply the 2026-06-10 audit remediation items
  • tighten GitHub workflow permissions, job timeouts, and scheduled/manual concurrency where applicable
  • add focused characterization or governance checks where this repository has runtime-facing changes

Validation

  • targeted local tests and lint checks were run before publishing
  • workflow governance scan passed across the remediation scope
  • git diff --check passed across the remediation scope

See local audit report: QuantStrategyLab-review-2026-06-10.md.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5015fc9bf1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

sync-cloud-run-env:
name: Deploy / Sync Cloud Run
runs-on: ubuntu-latest
timeout-minutes: 20

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Raise deploy job timeout above wait loop

When ENABLE_GITHUB_ENV_SYNC is true, this same job can enter the existing “Wait for Cloud Run deployment of current commit” step, which sets deadline=$((SECONDS + 1800)) and sleeps until another deployment lands the current SHA. The new 20-minute job timeout will kill the workflow before that 30-minute wait can complete, and it also has to cover checkout, dependency installation, auth, and any optional image build first, so legitimate env-sync runs can now fail before their own timeout/error handling is reached.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit 8dfb099 into main Jun 10, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/report-remediation-20260610 branch June 10, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant