Skip to content

Route monthly review to self-hosted Codex bridge#57

Merged
Pigbibi merged 1 commit into
mainfrom
codex/selfhosted-audit-bridge
May 23, 2026
Merged

Route monthly review to self-hosted Codex bridge#57
Pigbibi merged 1 commit into
mainfrom
codex/selfhosted-audit-bridge

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 23, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@Pigbibi Pigbibi merged commit 63c4adb into main May 23, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/selfhosted-audit-bridge branch May 23, 2026 12:15

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8026f54626

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +203 to +206
if: success() && env.PUBLISH_ENABLED != 'false' && env.SELFHOSTED_CODEX_REVIEW_ENABLED != 'false'
env:
APP_TOKEN: ${{ steps.codex_review_app_token.outputs.token }}
CODEX_AUDIT_DISPATCH_TOKEN: ${{ secrets.CODEX_AUDIT_DISPATCH_TOKEN }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Skip self-hosted dispatch when no token source is configured

This step runs whenever SELFHOSTED_CODEX_REVIEW_ENABLED is not 'false' (default is 'true'), but it hard-fails if neither APP_TOKEN nor CODEX_AUDIT_DISPATCH_TOKEN is present. In repositories/environments that have not added the new cross-repo app secret or dispatch token yet, monthly publish will now fail after creating the issue, which is a regression from the previous in-repo dispatch path. The dispatch step should be gated on credential availability (or self-hosted should default to disabled) so publish is not blocked by missing review-bridge secrets.

Useful? React with 👍 / 👎.

Comment on lines +198 to +199
repositories: |
SelfHostedCodexAuditBridge

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use configured target repo when minting GitHub App token

The workflow exposes SELFHOSTED_CODEX_REVIEW_REPOSITORY as configurable, but the app-token step is still hardcoded to SelfHostedCodexAuditBridge. If the target repository variable is changed, the generated installation token remains scoped to the hardcoded repo and the subsequent dispatch to the configured repo can fail with authorization/not-found errors, making the configuration option partially ineffective unless a separate fallback token is supplied.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant