Configure Firstrade execution window retries#19
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0dcb23feb3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| raw_value = os.getenv("FIRSTRADE_TECH_RUNTIME_EXECUTION_WINDOW_TRADING_DAYS") | ||
| raw_value = os.getenv("FIRSTRADE_RUNTIME_EXECUTION_WINDOW_TRADING_DAYS") | ||
| env_name = "FIRSTRADE_RUNTIME_EXECUTION_WINDOW_TRADING_DAYS" | ||
| if raw_value is None and strategy_profile == "tech_communication_pullback_enhancement": |
There was a problem hiding this comment.
For tech_communication_pullback_enhancement, the legacy fallback is only used when FIRSTRADE_RUNTIME_EXECUTION_WINDOW_TRADING_DAYS is None, not when it is present-but-empty. With the new .env.example line, teams commonly end up with FIRSTRADE_RUNTIME_EXECUTION_WINDOW_TRADING_DAYS= in local/env files; in that case this branch is skipped, FIRSTRADE_TECH_RUNTIME_EXECUTION_WINDOW_TRADING_DAYS is ignored, and the runtime window override silently disappears. This breaks the intended backward-compatible fallback path for existing tech deployments.
Useful? React with 👍 / 👎.
1 participant
Summary
Tests