Skip to content

Align Firstrade execution block messaging#20

Merged
Pigbibi merged 1 commit into
mainfrom
codex/firstrade-docs-i18n-funding-block
May 24, 2026
Merged

Align Firstrade execution block messaging#20
Pigbibi merged 1 commit into
mainfrom
codex/firstrade-docs-i18n-funding-block

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • document strategy-run stages and terminal/non-terminal retry behavior
  • expose strategy_run_stage in run results using the same stage resolution as persistence
  • add bilingual notification banners for retryable execution blocks and terminal funding blocks

Tests

  • .venv/bin/python -m pytest -q

@Pigbibi Pigbibi merged commit b915a49 into main May 24, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/firstrade-docs-i18n-funding-block branch May 24, 2026 10:25

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 590a96baea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread notifications/telegram.py
Comment on lines +564 to +566
if bool(result.get("funding_blocked")):
banner_key = "funding_blocked_banner"
elif result.get("execution_block_retryable") is True:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Prefer retryable banner when retries are still enabled

In partial-submission runs, run_strategy_cycle can set funding_blocked=True while still setting execution_block_retryable=True (because only terminal funding blocks disable retries), but this branch always chooses funding_blocked_banner first and tells users there will be no more automatic retries. That produces incorrect operator guidance for PARTIAL_SUBMITTED runs where the scheduler should still retry within the window.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant