Align Firstrade execution block messaging#20
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 590a96baea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if bool(result.get("funding_blocked")): | ||
| banner_key = "funding_blocked_banner" | ||
| elif result.get("execution_block_retryable") is True: |
There was a problem hiding this comment.
Prefer retryable banner when retries are still enabled
In partial-submission runs, run_strategy_cycle can set funding_blocked=True while still setting execution_block_retryable=True (because only terminal funding blocks disable retries), but this branch always chooses funding_blocked_banner first and tells users there will be no more automatic retries. That produces incorrect operator guidance for PARTIAL_SUBMITTED runs where the scheduler should still retry within the window.
Useful? React with 👍 / 👎.
Summary
Tests