Skip to content

Rename Google Voice config to recipients#30

Merged
Pigbibi merged 1 commit into
mainfrom
google-voice-recipients-config
May 25, 2026
Merged

Rename Google Voice config to recipients#30
Pigbibi merged 1 commit into
mainfrom
google-voice-recipients-config

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • rename Google Voice notification destination config from gateway to recipients
  • document that recipients are email-form addresses: normal mailboxes receive email, Google Voice mailboxes/addresses can also trigger GV prompts
  • update QPK and strategy dependency pins to the recipients config commits
  • keep old GOOGLE_VOICE_TO and GOOGLE_VOICE_GATEWAY env names in Cloud Run cleanup lists

Tests

  • PYTHONPATH=/home/ubuntu/Projects/QuantPlatformKit/src:/home/ubuntu/Projects/UsEquityStrategies/src:. .venv/bin/python -m pytest tests/test_runtime_config_support.py tests/test_rebalance_service.py tests/test_sync_cloud_run_env_workflow.py
  • .venv/bin/python -m ruff check . (not run: Firstrade .venv has no ruff module)

@Pigbibi Pigbibi merged commit 95f87fe into main May 25, 2026
1 check passed
@Pigbibi Pigbibi deleted the google-voice-recipients-config branch May 25, 2026 09:35

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1fed953405

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread runtime_config_support.py
or os.getenv("STRATEGY_PLUGIN_MOUNTS_JSON")
),
crisis_alert_google_voice_gateway=_split_env_list(os.getenv("CRISIS_ALERT_GOOGLE_VOICE_GATEWAY")),
crisis_alert_google_voice_recipients=_split_env_list(os.getenv("CRISIS_ALERT_GOOGLE_VOICE_RECIPIENTS")),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Read legacy Google Voice env during migration

The runtime settings now read only CRISIS_ALERT_GOOGLE_VOICE_RECIPIENTS, so deployments that still have only the previous CRISIS_ALERT_GOOGLE_VOICE_GATEWAY variable (for example, environments where vars were not renamed yet or env-sync is disabled) will resolve an empty recipient list and stop sending Google Voice alerts after this release. Please keep a temporary fallback to the legacy env key while migrating existing environments.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant