Skip to content

Generalize Google Voice sender config#31

Merged
Pigbibi merged 1 commit into
mainfrom
google-voice-generic-sender-config
May 25, 2026
Merged

Generalize Google Voice sender config#31
Pigbibi merged 1 commit into
mainfrom
google-voice-generic-sender-config

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • rename Google Voice sender config from Gmail-specific names to provider-neutral SENDER_* names
  • add optional SMTP host/port/security overrides for non-Gmail senders while keeping Gmail SMTP defaults in QPK
  • update QPK/strategy pins and Cloud Run env sync cleanup for old GMAIL_* names

Tests

  • PYTHONPATH=/home/ubuntu/Projects/QuantPlatformKit/src:/home/ubuntu/Projects/UsEquityStrategies/src:. .venv/bin/python -m pytest tests/test_runtime_config_support.py tests/test_rebalance_service.py tests/test_sync_cloud_run_env_workflow.py
  • .venv/bin/python -m ruff check . (not run: Firstrade .venv has no ruff module)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5d36bb1073

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread runtime_config_support.py
Comment on lines +155 to +157
crisis_alert_google_voice_sender_email=_first_non_empty(os.getenv("CRISIS_ALERT_GOOGLE_VOICE_SENDER_EMAIL")),
crisis_alert_google_voice_sender_password=_first_non_empty(
os.getenv("CRISIS_ALERT_GOOGLE_VOICE_SENDER_PASSWORD")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve legacy Google Voice env fallback during rename

This change drops support for CRISIS_ALERT_GOOGLE_VOICE_GMAIL_USER/CRISIS_ALERT_GOOGLE_VOICE_GMAIL_APP_PASSWORD without a fallback, so deployments that still have only the old vars configured will silently lose Google Voice sender credentials after this commit. That failure path is realistic because the workflow can skip env-sync when ENABLE_GITHUB_ENV_SYNC is not true (see .github/workflows/sync-cloud-run-env.yml), leaving old Cloud Run vars in place while the runtime now reads only the new names. Please keep reading the legacy names as a fallback until all environments are migrated.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit 7ccc4b3 into main May 25, 2026
1 check passed
@Pigbibi Pigbibi deleted the google-voice-generic-sender-config branch May 25, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant