Generalize Google Voice sender config#31
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d36bb1073
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| crisis_alert_google_voice_sender_email=_first_non_empty(os.getenv("CRISIS_ALERT_GOOGLE_VOICE_SENDER_EMAIL")), | ||
| crisis_alert_google_voice_sender_password=_first_non_empty( | ||
| os.getenv("CRISIS_ALERT_GOOGLE_VOICE_SENDER_PASSWORD") |
There was a problem hiding this comment.
Preserve legacy Google Voice env fallback during rename
This change drops support for CRISIS_ALERT_GOOGLE_VOICE_GMAIL_USER/CRISIS_ALERT_GOOGLE_VOICE_GMAIL_APP_PASSWORD without a fallback, so deployments that still have only the old vars configured will silently lose Google Voice sender credentials after this commit. That failure path is realistic because the workflow can skip env-sync when ENABLE_GITHUB_ENV_SYNC is not true (see .github/workflows/sync-cloud-run-env.yml), leaving old Cloud Run vars in place while the runtime now reads only the new names. Please keep reading the legacy names as a fallback until all environments are migrated.
Useful? React with 👍 / 👎.
Summary
Tests