Skip to content

Localize signal snapshot source in notifications#51

Merged
Pigbibi merged 1 commit into
mainfrom
codex/localize-signal-snapshot-sources-20260529
May 28, 2026
Merged

Localize signal snapshot source in notifications#51
Pigbibi merged 1 commit into
mainfrom
codex/localize-signal-snapshot-sources-20260529

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • render signal snapshot price sources with localized labels instead of raw enum values
  • localize quote-overlay yes/no/unknown through QuantPlatformKit helpers

Verification

  • PYTHONPATH=.:../QuantPlatformKit/src ../QuantPlatformKit/.venv/bin/python -m py_compile notifications/telegram.py
  • PYTHONPATH=.:../QuantPlatformKit/src ../QuantPlatformKit/.venv/bin/ruff check notifications/telegram.py
  • git diff --check

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: df7b510eb4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread notifications/telegram.py Outdated
Comment on lines +10 to +11
localize_price_source_label as _localize_price_source_label,
localize_quote_overlay_state as _localize_quote_overlay_state,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep imports compatible with pinned QuantPlatformKit

In the CI and Docker paths I checked, the app installs requirements.txt, which pins QuantPlatformKit to 86d72631c76f27c668b234704b91241bec8fa9ee; that version's common.notification_localization only exports localize_notification_text, not these two new helpers. With the pinned dependency, importing notifications.telegram now raises ImportError before any notification code can run, so either the requirements pin needs to be advanced with this change or these helpers need a local compatibility fallback.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi force-pushed the codex/localize-signal-snapshot-sources-20260529 branch from df7b510 to bfacaeb Compare May 28, 2026 20:05
@Pigbibi Pigbibi merged commit 2764bf2 into main May 28, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/localize-signal-snapshot-sources-20260529 branch May 28, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant