Infer quote overlay state in notifications#52
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 46701b7753
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if normalized_source in { | ||
| "longbridge_candlesticks", | ||
| "historical_close", | ||
| "snapshot_close", | ||
| "market_quote", | ||
| }: |
There was a problem hiding this comment.
Classify mixed market quote sources as no-overlay
When latest_price_source is mixed_market_quote_snapshot_close or mixed_market_quote_historical_close (both recognized source names in this module's localization table), this inference still returns None because those names are not in the no-overlay set and do not contain with_live_quote_overlay. Since build_signal_snapshot() leaves absent quote_overlay_used as None, notifications for those known non-overlay sources will continue to render quote overlay unknown, defeating the new inference for those snapshot source names.
Useful? React with 👍 / 👎.
Summary
Verification