Skip to content

Infer quote overlay state in notifications#52

Merged
Pigbibi merged 1 commit into
mainfrom
codex/infer-quote-overlay-state-20260529
May 29, 2026
Merged

Infer quote overlay state in notifications#52
Pigbibi merged 1 commit into
mainfrom
codex/infer-quote-overlay-state-20260529

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • infer quote-overlay state from known signal snapshot source names
  • keep explicit quote_overlay_used values authoritative

Verification

  • PYTHONPATH=.:../QuantPlatformKit/src ../QuantPlatformKit/.venv/bin/python -m py_compile notifications/telegram.py
  • PYTHONPATH=.:../QuantPlatformKit/src ../QuantPlatformKit/.venv/bin/ruff check notifications/telegram.py
  • git diff --check

@Pigbibi Pigbibi merged commit 60a8bf8 into main May 29, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/infer-quote-overlay-state-20260529 branch May 29, 2026 03:39

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 46701b7753

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread notifications/telegram.py
Comment on lines +562 to +567
if normalized_source in {
"longbridge_candlesticks",
"historical_close",
"snapshot_close",
"market_quote",
}:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Classify mixed market quote sources as no-overlay

When latest_price_source is mixed_market_quote_snapshot_close or mixed_market_quote_historical_close (both recognized source names in this module's localization table), this inference still returns None because those names are not in the no-overlay set and do not contain with_live_quote_overlay. Since build_signal_snapshot() leaves absent quote_overlay_used as None, notifications for those known non-overlay sources will continue to render quote overlay unknown, defeating the new inference for those snapshot source names.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant