Skip to content

Use sellable quantity for Firstrade stale sell values#6

Merged
Pigbibi merged 1 commit into
mainfrom
fix/firstrade-sell-quantity-stale-value
May 22, 2026
Merged

Use sellable quantity for Firstrade stale sell values#6
Pigbibi merged 1 commit into
mainfrom
fix/firstrade-sell-quantity-stale-value

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Use sellable quantity and current quote to prevent stale market values from under-sizing Firstrade sell orders.
  • Preserve max order notional caps while allowing target-zero liquidation to sell the full available quantity when the cap allows it.
  • Add regression coverage for the SOXL stale-value case.

Test

  • python -m pytest tests/test_execution_service.py -q

@Pigbibi Pigbibi merged commit 64397fb into main May 22, 2026
1 check passed
@Pigbibi Pigbibi deleted the fix/firstrade-sell-quantity-stale-value branch May 22, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant