Add Firstrade Cloud Run deployment#8
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd39229712
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [ -z "${NOTIFY_LANG:-}" ]; then | ||
| required_vars+=(NOTIFY_LANG) | ||
| fi |
There was a problem hiding this comment.
Keep NOTIFY_LANG optional in env-sync validation
This block adds NOTIFY_LANG to required_vars whenever it is unset, so any run with ENABLE_GITHUB_ENV_SYNC=true fails validation unless NOTIFY_LANG is explicitly provided. The runtime path already has a default (runtime_config_support.py uses os.getenv("NOTIFY_LANG", "en")), so this introduces a new deployment failure for previously valid configurations where language is intentionally omitted.
Useful? React with 👍 / 👎.
Summary
Validation
Notes