Skip to content

Add Firstrade Cloud Run deployment#8

Merged
Pigbibi merged 1 commit into
mainfrom
firstrade-gcp-deploy
May 23, 2026
Merged

Add Firstrade Cloud Run deployment#8
Pigbibi merged 1 commit into
mainfrom
firstrade-gcp-deploy

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add Cloud Build config and GitHub Actions deployment workflow for firstradequant Cloud Run
  • allow Scheduler POST requests on /, /precheck, and /probe
  • add gunicorn runtime config and request-route coverage

Validation

  • python -m py_compile main.py
  • gcloud builds submit deployed firstrade-quant-service successfully in firstradequant
  • Cloud Scheduler manual probe run completed without error

Notes

  • ENABLE_GITHUB_ENV_SYNC is currently false because Firstrade credential secret versions are not populated yet
  • the main execution scheduler is created but paused until credentials and live/dry-run gates are explicitly enabled

@Pigbibi Pigbibi merged commit 172736b into main May 23, 2026
1 check passed
@Pigbibi Pigbibi deleted the firstrade-gcp-deploy branch May 23, 2026 04:17

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fd39229712

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +233 to +235
if [ -z "${NOTIFY_LANG:-}" ]; then
required_vars+=(NOTIFY_LANG)
fi

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep NOTIFY_LANG optional in env-sync validation

This block adds NOTIFY_LANG to required_vars whenever it is unset, so any run with ENABLE_GITHUB_ENV_SYNC=true fails validation unless NOTIFY_LANG is explicitly provided. The runtime path already has a default (runtime_config_support.py uses os.getenv("NOTIFY_LANG", "en")), so this introduces a new deployment failure for previously valid configurations where language is intentionally omitted.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant