Skip to content

[codex] Apply audit remediation#155

Merged
Pigbibi merged 1 commit into
mainfrom
codex/report-remediation-20260610
Jun 10, 2026
Merged

[codex] Apply audit remediation#155
Pigbibi merged 1 commit into
mainfrom
codex/report-remediation-20260610

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • apply the 2026-06-10 audit remediation items
  • tighten GitHub workflow permissions, job timeouts, and scheduled/manual concurrency where applicable
  • add focused characterization or governance checks where this repository has runtime-facing changes

Validation

  • targeted local tests and lint checks were run before publishing
  • workflow governance scan passed across the remediation scope
  • git diff --check passed across the remediation scope

See local audit report: QuantStrategyLab-review-2026-06-10.md.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dcbb34cdf2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

sync-cloud-run-env:
name: Deploy / Sync Cloud Run
runs-on: ubuntu-latest
timeout-minutes: 20

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Raise deploy job timeout above wait loop

When env sync waits for Cloud Run to reach the current commit, the workflow still allows the wait loop to run for up to 1800 seconds per service, but this new 20-minute job timeout kills the entire job before that loop can reach its own deadline. In any deployment where image build/push/deploy plus propagation takes more than the remaining job time, the job now fails from the GitHub timeout instead of completing or emitting the script's intended timeout message, so the job timeout should be greater than the longest expected wait path.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit d6e3781 into main Jun 10, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/report-remediation-20260610 branch June 10, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant