[codex] Sync TQQQ risk diagnostics#157
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 309f0b2cb6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| timing_lines = _build_timing_audit_lines(metadata, translator=translator) | ||
| snapshot_line = _format_signal_snapshot_line(metadata.get("signal_snapshot"), translator=translator) | ||
| audit_lines = [*timing_lines, *([snapshot_line] if snapshot_line else [])] | ||
| audit_lines = [*risk_control_lines, *timing_lines, *([snapshot_line] if snapshot_line else [])] |
There was a problem hiding this comment.
Include risk diagnostics in compact notifications
When run_strategy_cycle publishes trade/no-op notifications, the user-facing Telegram copy comes from compact_text, whose dashboard_text is the separately computed application/rebalance_service._strategy_dashboard_text (application/rebalance_service.py lines 647 and 778/718), not this updated renderer helper; NotificationPublisher sends compact_text to Telegram. As a result, with dual_drive_volatility_delever_applied true, the new TQQQ risk line is present only in the detailed log dashboard and is omitted from the actual Telegram message, so the diagnostics this change is meant to surface still do not reach users in the main cycle path.
Useful? React with 👍 / 👎.
Summary
Validation