Skip to content

Localize signal snapshot source in notifications#101

Merged
Pigbibi merged 1 commit into
mainfrom
codex/localize-signal-snapshot-sources-20260529
May 28, 2026
Merged

Localize signal snapshot source in notifications#101
Pigbibi merged 1 commit into
mainfrom
codex/localize-signal-snapshot-sources-20260529

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • render signal snapshot price sources with localized broker labels instead of raw enum values
  • localize quote-overlay yes/no/unknown through QuantPlatformKit helpers
  • add coverage for the LongBridge SOXL/SOXX heartbeat snapshot copy

Verification

  • PYTHONPATH=.:../QuantPlatformKit/src:../UsEquityStrategies/src ../QuantPlatformKit/.venv/bin/pytest tests/test_notifications.py -q
  • PYTHONPATH=.:../QuantPlatformKit/src:../UsEquityStrategies/src ../QuantPlatformKit/.venv/bin/ruff check notifications/renderers.py tests/test_notifications.py
  • git diff --check

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2bc05c9339

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread notifications/renderers.py Outdated
Comment on lines +10 to +11
localize_price_source_label as _localize_price_source_label,
localize_quote_overlay_state as _localize_quote_overlay_state,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update QuantPlatformKit pin before importing new helpers

In a clean install from requirements.txt, this module imports quant-platform-kit at pinned commit 86d72631c76f27c668b234704b91241bec8fa9ee; checking that pinned notification_localization.py shows it only exports translator_uses_zh and localize_notification_text, not localize_price_source_label or localize_quote_overlay_state. These new imports therefore raise ImportError as soon as notifications.renderers is imported, preventing notification rendering and any startup path that imports it. Please update the dependency pin together with this change or keep local fallbacks.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi force-pushed the codex/localize-signal-snapshot-sources-20260529 branch from 2bc05c9 to 04e4234 Compare May 28, 2026 20:05
@Pigbibi Pigbibi merged commit e443cf1 into main May 28, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/localize-signal-snapshot-sources-20260529 branch May 28, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant