Localize signal snapshot source in notifications#101
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2bc05c9339
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| localize_price_source_label as _localize_price_source_label, | ||
| localize_quote_overlay_state as _localize_quote_overlay_state, |
There was a problem hiding this comment.
Update QuantPlatformKit pin before importing new helpers
In a clean install from requirements.txt, this module imports quant-platform-kit at pinned commit 86d72631c76f27c668b234704b91241bec8fa9ee; checking that pinned notification_localization.py shows it only exports translator_uses_zh and localize_notification_text, not localize_price_source_label or localize_quote_overlay_state. These new imports therefore raise ImportError as soon as notifications.renderers is imported, preventing notification rendering and any startup path that imports it. Please update the dependency pin together with this change or keep local fallbacks.
Useful? React with 👍 / 👎.
2bc05c9 to
04e4234
Compare
Summary
Verification