Enable HK-listed global ETF runtime profile#108
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8070fbb98
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@v0.7.35 | ||
| us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@v0.7.49 | ||
| hk-equity-strategies @ git+https://github.com/QuantStrategyLab/HkEquityStrategies.git@400ef6145bff0b89b46ec00ebb235987ac499a61 | ||
| hk-equity-strategies @ git+https://github.com/QuantStrategyLab/HkEquityStrategies.git@71141ce9e8a343cec8e2140994071eea66422bc6 |
There was a problem hiding this comment.
Route HK orders with the configured suffix
With this pin, the HK package now makes hk_listed_global_etf_rotation runtime-enabled, so load_platform_runtime_settings accepts it and sets symbol_suffix=.HK for ACCOUNT_REGION=HK. The execution path still ignores that suffix: execute_rebalance_cycle hard-codes order symbols as f"{symbol}.US" in the sell/buy submission branches (for example application/execution_service.py lines 704, 724, 969, and 988), and build_execution_port forwards the symbol directly to LongBridge. Any explicit HK rollout that tries to trade 02800, 03033, etc. will therefore submit invalid/wrong .US symbols instead of .HK, so the profile should not be enabled until order symbol formatting is parameterized by the runtime suffix.
Useful? React with 👍 / 👎.
Summary
hk-equity-strategiesto the merged commit that markshk_listed_global_etf_rotationas runtime-enabled.Validation
env -i HOME="$HOME" PATH="/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin" TMPDIR=/tmp PYTHONPATH=. PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 /tmp/qsl-longbridge-ci-venv/bin/python -m pytest -q testsin an isolated repo copy: 149 passed, 12 subtests passed./tmp/qsl-longbridge-ci-venv/bin/ruff check --exclude external .: passed.PYTHONPATH=. PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 /tmp/qsl-longbridge-ci-venv/bin/python -m compileall -q .: passed.git diff --check: passed.Deployment note
This PR only changes code-level profile enablement and dependency pinning. It does not update any Cloud Run service,
RUNTIME_TARGET_JSON,STRATEGY_PROFILE, or GCP Secret Manager value.