Use HK symbol suffix in LongBridge execution#111
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fdb8f303ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if "." in normalized: | ||
| return normalized |
There was a problem hiding this comment.
Preserve suffixing for class-share tickers
When a strategy emits an unsuffixed US class-share ticker such as BRK.B or BF.B, this new guard treats the class-share dot as if a market suffix is already present and sends BRK.B to quotes/order previews instead of the prior BRK.B.US. That regresses any profile/universe containing dotted tickers because LongBridge execution still needs the market suffix; this should check for the configured suffix specifically rather than any period.
Useful? React with 👍 / 👎.
Summary
LONGBRIDGE_SYMBOL_SUFFIXinto the rebalance execution cycle..USorder/quote hardcoding with suffix-aware market symbols while preserving.USdefaults..HKquotes/order previews and no broker submission.Validation
/tmp/qsl-longbridge-ci-venv/bin/python -m pytest -q tests/test_rebalance_service.py/tmp/qsl-longbridge-ci-venv/bin/python -m pytest -q/tmp/qsl-longbridge-ci-venv/bin/python -m compileall -q application testsgit diff --check