Skip to content

Use HK symbol suffix in LongBridge execution#111

Merged
Pigbibi merged 1 commit into
mainfrom
codex/hk-dry-run-smoke
May 31, 2026
Merged

Use HK symbol suffix in LongBridge execution#111
Pigbibi merged 1 commit into
mainfrom
codex/hk-dry-run-smoke

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Thread LONGBRIDGE_SYMBOL_SUFFIX into the rebalance execution cycle.
  • Replace .US order/quote hardcoding with suffix-aware market symbols while preserving .US defaults.
  • Add a HK dry-run regression test to ensure .HK quotes/order previews and no broker submission.
  • Clarify docs that the suffix applies to both market data and order symbols.

Validation

  • /tmp/qsl-longbridge-ci-venv/bin/python -m pytest -q tests/test_rebalance_service.py
  • /tmp/qsl-longbridge-ci-venv/bin/python -m pytest -q
  • /tmp/qsl-longbridge-ci-venv/bin/python -m compileall -q application tests
  • git diff --check

@Pigbibi Pigbibi merged commit 9f6e1c8 into main May 31, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/hk-dry-run-smoke branch May 31, 2026 20:56

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fdb8f303ac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +388 to +389
if "." in normalized:
return normalized

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve suffixing for class-share tickers

When a strategy emits an unsuffixed US class-share ticker such as BRK.B or BF.B, this new guard treats the class-share dot as if a market suffix is already present and sends BRK.B to quotes/order previews instead of the prior BRK.B.US. That regresses any profile/universe containing dotted tickers because LongBridge execution still needs the market suffix; this should check for the configured suffix specifically rather than any period.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant