Show snapshot input diagnostics#115
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 776cfca155
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "price_as_of": _json_safe( | ||
| _first_value(source.get("price_as_of"), source.get("snapshot_manifest_price_as_of")) | ||
| ), | ||
| "universe_as_of": _json_safe( | ||
| _first_value(source.get("universe_as_of"), source.get("snapshot_manifest_universe_as_of")) |
There was a problem hiding this comment.
Pass manifest metadata into signal snapshots
Reading snapshot_manifest_* keys here does not surface the new diagnostics in the normal rebalance/heartbeat path: LongBridgeRuntimeStrategyAdapters.resolve_rebalance_plan() receives them as evaluation metadata, decision_mapper.map_strategy_decision_to_plan() only emits the whitelisted execution fields, and run_strategy() calls build_signal_snapshot() with only execution={...} and allocation=... (no metadata/diagnostics). For strategies where the manifest diagnostics are supplied via runtime metadata, these fields remain None, so the newly added notification line never shows the intended price/universe/fallback data outside the direct unit test.
Useful? React with 👍 / 👎.
776cfca to
e3a2e99
Compare
e3a2e99 to
9022bbb
Compare
Summary
Tests