Skip to content

Show snapshot input diagnostics#115

Merged
Pigbibi merged 1 commit into
mainfrom
codex/snapshot-manifest-diagnostics
Jun 1, 2026
Merged

Show snapshot input diagnostics#115
Pigbibi merged 1 commit into
mainfrom
codex/snapshot-manifest-diagnostics

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • surface snapshot manifest input dates and source refresh metadata in signal snapshots
  • show price/universe/fallback diagnostics in heartbeat and rebalance notifications
  • bump QuantPlatformKit/US/HK strategy dependencies to compatible released tags
  • add display-name and rollout matrix coverage for the newly enabled HK high-dividend profile

Tests

  • PYTHONPATH=/home/ubuntu/Projects/LongBridgePlatform:/home/ubuntu/Projects/QuantPlatformKit/src:/home/ubuntu/Projects/UsEquityStrategies/src:/home/ubuntu/Projects/HkEquityStrategies/src /tmp/useq-snapshot-guardrails-venv/bin/python -m pytest tests -q
  • /tmp/useq-snapshot-guardrails-venv/bin/python -m py_compile application/signal_snapshot.py notifications/renderers.py notifications/telegram.py
  • timeout 180s /tmp/useq-snapshot-guardrails-venv/bin/python -m pip install --dry-run -r requirements.txt
  • git diff --check

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 776cfca155

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +171 to +175
"price_as_of": _json_safe(
_first_value(source.get("price_as_of"), source.get("snapshot_manifest_price_as_of"))
),
"universe_as_of": _json_safe(
_first_value(source.get("universe_as_of"), source.get("snapshot_manifest_universe_as_of"))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Pass manifest metadata into signal snapshots

Reading snapshot_manifest_* keys here does not surface the new diagnostics in the normal rebalance/heartbeat path: LongBridgeRuntimeStrategyAdapters.resolve_rebalance_plan() receives them as evaluation metadata, decision_mapper.map_strategy_decision_to_plan() only emits the whitelisted execution fields, and run_strategy() calls build_signal_snapshot() with only execution={...} and allocation=... (no metadata/diagnostics). For strategies where the manifest diagnostics are supplied via runtime metadata, these fields remain None, so the newly added notification line never shows the intended price/universe/fallback data outside the direct unit test.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi force-pushed the codex/snapshot-manifest-diagnostics branch from 776cfca to e3a2e99 Compare June 1, 2026 21:49
@Pigbibi Pigbibi force-pushed the codex/snapshot-manifest-diagnostics branch from e3a2e99 to 9022bbb Compare June 1, 2026 21:52
@Pigbibi Pigbibi merged commit 063696f into main Jun 1, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/snapshot-manifest-diagnostics branch June 1, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant