Skip to content

Carry snapshot diagnostics into execution#116

Merged
Pigbibi merged 1 commit into
mainfrom
codex/pass-snapshot-diagnostics-to-execution
Jun 1, 2026
Merged

Carry snapshot diagnostics into execution#116
Pigbibi merged 1 commit into
mainfrom
codex/pass-snapshot-diagnostics-to-execution

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • carry snapshot manifest diagnostic metadata from runtime evaluation into execution payloads
  • lets signal snapshots and notifications show price/universe/source fallback details even for no-execute monthly cadence decisions
  • add regression coverage in decision mapper

Tests

  • PYTHONPATH=/home/ubuntu/Projects/LongBridgePlatform:/home/ubuntu/Projects/QuantPlatformKit/src:/home/ubuntu/Projects/UsEquityStrategies/src:/home/ubuntu/Projects/HkEquityStrategies/src /tmp/useq-snapshot-guardrails-venv/bin/python -m pytest tests -q
  • /tmp/useq-snapshot-guardrails-venv/bin/python -m py_compile decision_mapper.py application/signal_snapshot.py notifications/renderers.py notifications/telegram.py
  • git diff --check

@Pigbibi Pigbibi merged commit 7769d54 into main Jun 1, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/pass-snapshot-diagnostics-to-execution branch June 1, 2026 22:24

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c39416713a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread decision_mapper.py
plan["portfolio"]["cash_by_currency"] = cash_by_currency
_attach_snapshot_diagnostics(
plan,
decision=normalized_decision,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve original decision diagnostics when attaching snapshot data

When a no_execute decision carries snapshot manifest fields in decision.diagnostics, _normalize_to_value_target_decision replaces it with a synthetic hold-current decision whose diagnostics are empty, so passing normalized_decision here drops the very fields this helper tries to copy into execution. In that scenario the signal snapshot/notification still won't show the manifest dates or fallback status unless the same values also happen to be duplicated in runtime_metadata; use the original decision (or merge its diagnostics before normalization) for this attachment step.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant