Add execution report heartbeat alerts#119
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d9b850366b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| RUNTIME_HEARTBEAT_ACCOUNT_SCOPE: ${{ vars.ACCOUNT_REGION }} | ||
| RUNTIME_HEARTBEAT_REQUIRED_SERVICES: ${{ vars.RUNTIME_HEARTBEAT_REQUIRED_SERVICES || vars.CLOUD_RUN_SERVICE }} | ||
| RUNTIME_HEARTBEAT_GCS_URIS: ${{ vars.RUNTIME_HEARTBEAT_GCS_URIS || vars.EXECUTION_REPORT_GCS_URI }} | ||
| RUNTIME_HEARTBEAT_LOOKBACK_HOURS: ${{ inputs.lookback_hours || vars.RUNTIME_HEARTBEAT_LOOKBACK_HOURS || '36' }} |
There was a problem hiding this comment.
Tighten the default heartbeat window
With the scheduled job running only once per weekday at 23:25 UTC, the 36-hour default can let yesterday's accepted report satisfy today's check. For example, if the PAPER/US service wrote a report after Monday's close and then misses all Tuesday scheduler runs, Tuesday's heartbeat still finds that report within 36 hours and returns OK, so the missed daily completion is not alerted. Use a window that cannot include the prior trading day's completion, or derive the expected window per market/day.
Useful? React with 👍 / 👎.
Summary
Validation