Skip to content

Harden scheduler switch guards#149

Merged
Pigbibi merged 1 commit into
mainfrom
harden/scheduler-switch-guards
Jun 10, 2026
Merged

Harden scheduler switch guards#149
Pigbibi merged 1 commit into
mainfrom
harden/scheduler-switch-guards

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • make heartbeat named scheduler fallback handle service-name aliases
  • derive runtime guard scheduler filters from configured services when no explicit pattern is set
  • add targeted tests for scheduler alias handling

Tests

  • python -m pytest tests/test_execution_report_heartbeat.py tests/test_cloud_run_runtime_guard.py
  • git diff --check

@Pigbibi Pigbibi merged commit 0cc752f into main Jun 10, 2026
1 check passed
@Pigbibi Pigbibi deleted the harden/scheduler-switch-guards branch June 10, 2026 06:34

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a706fe3a1b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

continue
candidates.append(service_name)
if service_name.endswith("-service"):
candidates.append(service_name.removesuffix("-service"))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Anchor derived scheduler aliases

When RUNTIME_GUARD_SCHEDULER_JOB_PATTERN is unset, adding the stripped alias as a bare regex alternative makes the runtime guard match sibling jobs that only share the prefix. For example, with configured service longbridge-quant-hk-service, the generated longbridge\-quant\-hk alternative also matches longbridge-quant-hk-verify-service-scheduler, so a failure in that separate scheduler job would be reported against this guard run. Please constrain the generated alternatives to the intended scheduler job names or boundaries.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant