Decouple LongBridge notification delivery sink#31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR separates rendered strategy notifications from their delivery sinks in LongBridgePlatform.
The immediate issue is that strategy cycle code was still directly pairing detailed log output with compact Telegram delivery at each send point. That made it too easy for future notification changes to drift between logs and Telegram, and it kept delivery details mixed into strategy cycle flow.
The fix adds a RenderedNotification envelope and NotificationPublisher in the notification layer, routes strategy cycle summaries and error notifications through that publisher, and keeps LongBridge-specific prefixing at the delivery edge. Existing message content, order logic, dry-run behavior, and USD cash gating are unchanged.
Validation