Skip to content

Clean up fractional sizing support#45

Merged
Pigbibi merged 3 commits into
mainfrom
codex/review-fractional-cleanups
May 6, 2026
Merged

Clean up fractional sizing support#45
Pigbibi merged 3 commits into
mainfrom
codex/review-fractional-cleanups

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • share quantity-step env parsing through QuantPlatformKit and update the pin
  • sell full sellable quantity when a target is zero, avoiding residual shares from quote drift
  • document LongBridge quantity-step precedence and liquidation sizing behavior

Tests

  • ./.venv/bin/python -m pytest tests/test_runtime_config_support.py tests/test_rebalance_service.py::RebalanceServiceNotificationTests::test_zero_target_sell_uses_sellable_quantity_not_price_derived_floor tests/test_rebalance_service.py::RebalanceServiceNotificationTests::test_fractional_quantity_step_allows_small_soxx_target_buy tests/test_rebalance_service.py::RebalanceServiceNotificationTests::test_fractional_buy_uses_budget_when_broker_estimate_is_whole_share_zero

Holding merge until CI and Codex review comments are addressed.

@Pigbibi Pigbibi merged commit e0c737d into main May 6, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/review-fractional-cleanups branch May 6, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant