Skip to content

Make LongBridge API probe credential loading flexible#53

Merged
Pigbibi merged 1 commit into
mainfrom
codex/longbridge-api-probe-secret-fallback
May 7, 2026
Merged

Make LongBridge API probe credential loading flexible#53
Pigbibi merged 1 commit into
mainfrom
codex/longbridge-api-probe-secret-fallback

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • let the manual LongBridge API probe use GitHub Environment secrets when present
  • keep Secret Manager as the normal source, with a runtime service account impersonation fallback for deployments where the OIDC deploy service account cannot read secret versions directly
  • document the alternate credential source and expand workflow structure coverage

Validation

  • /home/ubuntu/Projects/LongBridgePlatform/.venv/bin/python -m unittest tests.test_longbridge_api_probe_workflow -v
  • bash tests/test_longbridge_api_probe_workflow.sh
  • /home/ubuntu/Projects/LongBridgePlatform/.venv/bin/python -m ruff check tests/test_longbridge_api_probe_workflow.py
  • git diff --check

Context

The first manual HK probe run reached Google Cloud auth but failed before broker API execution because longbridge-platform-deploy@longbridgequant does not have secretmanager.versions.access on the LongPort credential secrets.

@Pigbibi Pigbibi marked this pull request as ready for review May 7, 2026 21:19
@Pigbibi Pigbibi merged commit 17442d1 into main May 7, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/longbridge-api-probe-secret-fallback branch May 7, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant