Require LongBridge runtime target JSON#56
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9774324326
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | `LONGPORT_SECRET_NAME` | No | Secret Manager secret name for LongPort token (default: `longport_token_hk`) | | ||
| | `LONGPORT_APP_KEY` | Yes | LongPort OpenAPI app key (for token refresh); recommended to inject from the region-specific Secret Manager secret for this deployment, such as `longport-app-key-paper` / `longport-app-key-hk` / `longport-app-key-sg` | | ||
| | `LONGPORT_APP_SECRET` | Yes | LongPort OpenAPI app secret (for token refresh); recommended to inject from the region-specific Secret Manager secret for this deployment, such as `longport-app-secret-paper` / `longport-app-secret-hk` / `longport-app-secret-sg` | | ||
| | `LONGPORT_SECRET_NAME` | No | Secret Manager secret name for LongPort token (default: `longport_token_paper`) | |
There was a problem hiding this comment.
The new docs now state that LONGPORT_SECRET_NAME defaults to longport_token_paper, but the runtime fallback is still longport_token_hk (runtime_config_support.py, DEFAULT_LONGPORT_SECRET_NAME). In deployments that rely on the default (for example local/manual runs or any path that doesn't force LONGPORT_SECRET_NAME), this can silently point the PAPER service at the HK token secret and execute against the wrong account context.
Useful? React with 👍 / 👎.
1 participant
Summary
RUNTIME_TARGET_JSONTests
PYTHONPATH=.:../QuantPlatformKit/src /home/ubuntu/Projects/LongBridgePlatform/.venv/bin/python -m pytest tests/test_runtime_config_support.py tests/test_notifications.py -qbash tests/test_sync_cloud_run_env_workflow.sh