Skip to content

Separate Google Voice alert configuration#79

Merged
Pigbibi merged 2 commits into
mainfrom
separate-google-voice-config
May 25, 2026
Merged

Separate Google Voice alert configuration#79
Pigbibi merged 2 commits into
mainfrom
separate-google-voice-config

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • move crisis plugin Google Voice settings to CRISIS_ALERT_GOOGLE_VOICE_* names
  • sync the new Google Voice/Gmail vars into Cloud Run and remove legacy CRISIS_ALERT_SMTP_* vars
  • update QuantPlatformKit pin to 2de98b250b437ecb2076197b34de291df080e760

Tests

  • PYTHONPATH=/home/ubuntu/Projects/QuantPlatformKit/src:/home/ubuntu/Projects/UsEquityStrategies/src:. .venv/bin/python -m pytest tests/test_runtime_config_support.py tests/test_request_handling.py
  • bash tests/test_sync_cloud_run_env_workflow.sh
  • .venv/bin/python -m ruff check .

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 71ca8d7f66

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +300 to +304
"CRISIS_ALERT_GOOGLE_VOICE_TO"
"CRISIS_ALERT_SMTP_FROM"
"CRISIS_ALERT_SMTP_HOST"
"CRISIS_ALERT_SMTP_PORT"
"CRISIS_ALERT_SMTP_USERNAME"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep legacy crisis vars until replacements are populated

This unconditionally schedules removal of the legacy Google Voice/SMTP env keys during every sync, even when the new CRISIS_ALERT_GOOGLE_VOICE_* variables are unset. In environments that have not fully migrated GitHub Environment variables yet, the workflow will clear the currently working crisis-alert configuration and silently disable alert delivery after update. Please gate legacy removal on the new config being present (or keep temporary fallback reads) so migration cannot turn alerts off.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit 2bcac19 into main May 25, 2026
1 check passed
@Pigbibi Pigbibi deleted the separate-google-voice-config branch May 25, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant