Separate Google Voice alert configuration#79
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71ca8d7f66
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "CRISIS_ALERT_GOOGLE_VOICE_TO" | ||
| "CRISIS_ALERT_SMTP_FROM" | ||
| "CRISIS_ALERT_SMTP_HOST" | ||
| "CRISIS_ALERT_SMTP_PORT" | ||
| "CRISIS_ALERT_SMTP_USERNAME" |
There was a problem hiding this comment.
Keep legacy crisis vars until replacements are populated
This unconditionally schedules removal of the legacy Google Voice/SMTP env keys during every sync, even when the new CRISIS_ALERT_GOOGLE_VOICE_* variables are unset. In environments that have not fully migrated GitHub Environment variables yet, the workflow will clear the currently working crisis-alert configuration and silently disable alert delivery after update. Please gate legacy removal on the new config being present (or keep temporary fallback reads) so migration cannot turn alerts off.
Useful? React with 👍 / 👎.
Summary
Tests