Skip to content

Keep strategy plugins out of cycle notifications #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
May 26, 2026
Merged

Keep strategy plugins out of cycle notifications #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions application/runtime_composer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ def build_rebalance_runtime(self, *, silent_cycle_notifications: bool = False) -
)

def build_rebalance_config(self, *, strategy_plugin_signals=()) -> LongBridgeRebalanceConfig:
del strategy_plugin_signals
return LongBridgeRebalanceConfig(
limit_sell_discount=self.limit_sell_discount,
limit_buy_premium=self.limit_buy_premium,
Expand All @@ -187,11 +188,7 @@ def build_rebalance_config(self, *, strategy_plugin_signals=()) -> LongBridgeReb
post_sell_refresh_interval_sec=self.order_poll_interval_sec,
safe_haven_cash_substitute_threshold_usd=self.safe_haven_cash_substitute_threshold_usd,
sleeper=self.sleeper,
extra_notification_lines=getattr(
self.strategy_adapters,
"build_strategy_plugin_notification_lines",
lambda _signals: (),
)(strategy_plugin_signals),
extra_notification_lines=(),
)

def load_strategy_plugin_signals(self, raw_mounts):
Expand Down
2 changes: 1 addition & 1 deletion main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ def run_strategy(*, force_run: bool = False, validation_only: bool = False, vali
runtime=composer.build_rebalance_runtime(
silent_cycle_notifications=validation_only,
),
config=composer.build_rebalance_config(strategy_plugin_signals=strategy_plugin_signals),
config=composer.build_rebalance_config(),
)
finalize_runtime_report(report, status="ok")
reporting_adapters.log_event(
Expand Down