Skip to content

Add shared execution outcome notifications#44

Merged
Pigbibi merged 1 commit into
mainfrom
codex/unify-notification-outcomes
May 24, 2026
Merged

Add shared execution outcome notifications#44
Pigbibi merged 1 commit into
mainfrom
codex/unify-notification-outcomes

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add shared execution outcome/stage helpers for platform runtimes
  • add shared notification envelope and publisher helpers
  • document that platform repos should keep broker differences behind adapters and transport wiring

Tests

  • .venv/bin/python -m pytest -q

@Pigbibi Pigbibi merged commit 9c4ea78 into main May 24, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/unify-notification-outcomes branch May 24, 2026 11:20

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1d9bd5d2f1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +18 to +24
DEFAULT_TERMINAL_STRATEGY_RUN_STAGES = frozenset(
{
STAGE_SUBMITTED,
STAGE_FUNDING_BLOCKED,
STAGE_RECONCILED,
STAGE_COMPLETED,
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Include dry-run and no-action in terminal stage set

resolve_strategy_run_stage can return DRY_RUN_COMPLETED (when dry_run_only=True) and NO_ACTION (when nothing is executed), but DEFAULT_TERMINAL_STRATEGY_RUN_STAGES excludes both values. Any caller that uses is_terminal_strategy_run_stage with the default set will misclassify these finished runs as non-terminal, which can keep polling/retry loops alive for dry-run and no-op executions. The terminal set should include these returned terminal outcomes (or the resolver should stop emitting them).

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant