Add strategy plugin email alert publisher#47
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba67541711
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if self.local_dir: | ||
| return self._local_path(alert_key).exists() | ||
| return False |
There was a problem hiding this comment.
Enable local marker checks when no backend is configured
When StrategyPluginEmailAlertMarkerStore is instantiated with defaults (local_dir=None, gcs_prefix_uri=None), this branch makes has_alert() always return False, so duplicate suppression never activates for repeated runs. Because _local_path() already falls back to tempfile.gettempdir(), callers can reasonably expect default local persistence; instead, alerts are re-sent every time unless local_dir is explicitly set, which undermines the new idempotency behavior.
Useful? React with 👍 / 👎.
Summary
Tests