Skip to content

Add strategy plugin email alert publisher#47

Merged
Pigbibi merged 1 commit into
mainfrom
qsl/plugin-email-alert-publisher
May 24, 2026
Merged

Add strategy plugin email alert publisher#47
Pigbibi merged 1 commit into
mainfrom
qsl/plugin-email-alert-publisher

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a shared strategy plugin email alert publisher with structured sent/skipped/failed results
  • add alert context labels and stable alert keys for idempotency markers
  • document the shared SMTP escalation path

Tests

  • PYTHONPATH=src python -m pytest tests/test_email.py tests/test_strategy_plugins.py -q

@Pigbibi Pigbibi merged commit 625f26c into main May 24, 2026
1 check passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ba67541711

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +125 to +127
if self.local_dir:
return self._local_path(alert_key).exists()
return False

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Enable local marker checks when no backend is configured

When StrategyPluginEmailAlertMarkerStore is instantiated with defaults (local_dir=None, gcs_prefix_uri=None), this branch makes has_alert() always return False, so duplicate suppression never activates for repeated runs. Because _local_path() already falls back to tempfile.gettempdir(), callers can reasonably expect default local persistence; instead, alerts are re-sent every time unless local_dir is explicitly set, which undermines the new idempotency behavior.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi deleted the qsl/plugin-email-alert-publisher branch May 27, 2026 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant