Rename strategy plugin alert channel to Google Voice#48
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3322c95940
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return publish_strategy_plugin_google_voice_alerts( | ||
| signals, | ||
| google_voice_settings=email_settings, |
There was a problem hiding this comment.
publish_strategy_plugin_email_alerts() is documented as a compatibility alias, but it now delegates directly to the Google Voice publisher, which generates strategy_plugin_google_voice_alert/* keys. Any deployed caller that still uses the email API with an existing/custom alert_store keyed on legacy strategy_plugin_email_alert/* values will fail duplicate detection after upgrade and can resend alerts that were already acknowledged. This regression occurs specifically when historical markers exist under the old namespace and the store does not implement the new key-mapping logic.
Useful? React with 👍 / 👎.
1 participant
No description provided.