Generalize Google Voice sender config#54
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef80c0c4f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| use_starttls=settings.smtp_security == _SMTP_SECURITY_STARTTLS, | ||
| use_ssl=settings.smtp_security == _SMTP_SECURITY_SSL, |
There was a problem hiding this comment.
Validate smtp_security before deriving TLS flags
_send_message derives use_starttls/use_ssl by strict equality against two literals, so any unexpected smtp_security value (for example when callers construct StrategyPluginGoogleVoiceSettings(...) directly instead of from_object) disables both TLS modes. In that case the code attempts an unauthenticated/plain SMTP flow on whatever port is set, which can silently break delivery or downgrade transport security instead of falling back to the documented default (ssl). Consider normalizing/validating smtp_security on dataclass construction or adding a safe fallback in _send_message.
Useful? React with 👍 / 👎.
Summary
Tests