Skip to content

Generalize Google Voice sender config#54

Merged
Pigbibi merged 1 commit into
mainfrom
codex-googlevoice-generic-sender
May 25, 2026
Merged

Generalize Google Voice sender config#54
Pigbibi merged 1 commit into
mainfrom
codex-googlevoice-generic-sender

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • rename Google Voice sender config from Gmail-specific names to generic sender email/password
  • keep Gmail SMTP as the default transport so the common setup still needs only recipients, sender email, and sender password
  • add optional Google Voice channel-scoped SMTP host/port/security overrides for non-Gmail senders

Tests

  • PYTHONPATH=src pytest tests/test_google_voice_notifications.py tests/test_strategy_plugins.py
  • PYTHONPATH=src ruff check .

@Pigbibi Pigbibi merged commit 43b2ecb into main May 25, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex-googlevoice-generic-sender branch May 25, 2026 09:59

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ef80c0c4f4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +308 to +309
use_starttls=settings.smtp_security == _SMTP_SECURITY_STARTTLS,
use_ssl=settings.smtp_security == _SMTP_SECURITY_SSL,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Validate smtp_security before deriving TLS flags

_send_message derives use_starttls/use_ssl by strict equality against two literals, so any unexpected smtp_security value (for example when callers construct StrategyPluginGoogleVoiceSettings(...) directly instead of from_object) disables both TLS modes. In that case the code attempts an unauthenticated/plain SMTP flow on whatever port is set, which can silently break delivery or downgrade transport security instead of falling back to the documented default (ssl). Consider normalizing/validating smtp_security on dataclass construction or adding a safe fallback in _send_message.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant