Add push channel for strategy plugin alerts#61
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b960bff153
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if raw_channels in (None, "", (), []): | ||
| raw_channels = (_CHANNEL_EMAIL, _CHANNEL_SMS, _CHANNEL_PUSH) |
There was a problem hiding this comment.
Honor explicit empty channel selections
Treating ()/[]/"" as “unset” causes _resolve_channels to fall back to ("email", "sms", "push"), so callers that explicitly pass no channels (or load an intentionally empty crisis_alert_channels) now dispatch alerts instead of disabling delivery. This is a behavior regression from the previous logic where an empty selection normalized to no channels, and it can trigger unintended outbound notifications in production runs.
Useful? React with 👍 / 👎.
Summary
Tests