Skip to content

Add strategy plugin Telegram alert channel#62

Merged
Pigbibi merged 1 commit into
mainfrom
codex/strategy-plugin-telegram-alerts
May 25, 2026
Merged

Add strategy plugin Telegram alert channel#62
Pigbibi merged 1 commit into
mainfrom
codex/strategy-plugin-telegram-alerts

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add provider-neutral Telegram Bot API delivery for strategy plugin alerts
  • include Telegram in the alert dispatcher, marker stores, summaries, and public exports
  • document the new channel and bump package version to 0.7.30

Tests

  • PYTHONPATH=src pytest tests/test_telegram.py tests/test_strategy_plugin_telegram_notifications.py tests/test_strategy_plugin_alert_dispatcher.py tests/test_strategy_plugins.py -q
  • PYTHONPATH=src ruff check .

@Pigbibi Pigbibi merged commit b520bca into main May 25, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/strategy-plugin-telegram-alerts branch May 25, 2026 19:59

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5141311041

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +121 to +124
if status < 200 or status >= 300:
printer(f"Telegram send failed for {chat_id}: HTTP {status}", flush=True)
return False
return True

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Validate Telegram API ok before reporting success

_request_succeeded currently treats any HTTP 2xx as a successful delivery and never inspects the response JSON, even though Telegram responses include an ok field to indicate application-level success. If the API (or a proxy/self-hosted Bot API endpoint) returns HTTP 200 with ok: false, this path marks the send as successful; downstream, publish_strategy_plugin_telegram_alerts can record the alert marker and skip future retries, causing real alert drops.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant