Add strategy plugin Telegram alert channel#62
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5141311041
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if status < 200 or status >= 300: | ||
| printer(f"Telegram send failed for {chat_id}: HTTP {status}", flush=True) | ||
| return False | ||
| return True |
There was a problem hiding this comment.
Validate Telegram API
ok before reporting success
_request_succeeded currently treats any HTTP 2xx as a successful delivery and never inspects the response JSON, even though Telegram responses include an ok field to indicate application-level success. If the API (or a proxy/self-hosted Bot API endpoint) returns HTTP 200 with ok: false, this path marks the send as successful; downstream, publish_strategy_plugin_telegram_alerts can record the alert marker and skip future retries, causing real alert drops.
Useful? React with 👍 / 👎.
Summary
Tests