Align package version declarations#71
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 80368dbd40
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| from __future__ import annotations | ||
|
|
||
| import re | ||
| import tomllib |
There was a problem hiding this comment.
Use a Python 3.9-compatible TOML parser
This test module imports tomllib unconditionally, but the package still advertises requires-python = ">=3.9" in pyproject.toml and Ruff targets py39. On Python 3.9 or 3.10, collecting this new test fails immediately with ModuleNotFoundError: No module named 'tomllib', so the test suite breaks for supported interpreters; use a fallback such as tomli or avoid TOML parsing here.
Useful? React with 👍 / 👎.
Summary
setup.pyandquant_platform_kit.__version__withpyproject.toml(0.7.34)Tests
slowrun bash -lc ".venv/bin/python -m pytest tests/test_package_version.py -q && .venv/bin/ruff check setup.py src/quant_platform_kit/__init__.py tests/test_package_version.py"