Skip to content

Align package version declarations#71

Merged
Pigbibi merged 1 commit into
mainfrom
codex/package-version-consistency-20260528
May 28, 2026
Merged

Align package version declarations#71
Pigbibi merged 1 commit into
mainfrom
codex/package-version-consistency-20260528

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • align setup.py and quant_platform_kit.__version__ with pyproject.toml (0.7.34)
  • add a regression test that fails when package version declarations drift

Tests

  • slowrun bash -lc ".venv/bin/python -m pytest tests/test_package_version.py -q && .venv/bin/ruff check setup.py src/quant_platform_kit/__init__.py tests/test_package_version.py"

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 80368dbd40

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

from __future__ import annotations

import re
import tomllib

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use a Python 3.9-compatible TOML parser

This test module imports tomllib unconditionally, but the package still advertises requires-python = ">=3.9" in pyproject.toml and Ruff targets py39. On Python 3.9 or 3.10, collecting this new test fails immediately with ModuleNotFoundError: No module named 'tomllib', so the test suite breaks for supported interpreters; use a fallback such as tomli or avoid TOML parsing here.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit 4189142 into main May 28, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/package-version-consistency-20260528 branch May 28, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant