Align contributing checks with CI#39
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a02e766d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| git diff --check | ||
| python -m pytest -q | ||
| python3 scripts/runtime_settings.py validate | ||
| python3 -m unittest discover -s tests -v |
There was a problem hiding this comment.
Include web asset validation in local checks
For changes under web/strategy-switch-console, this documented local test set still does not match CI: .github/workflows/validate.yml runs sync_strategy_switch_page_asset.py, checks generated asset diffs/JQ, executes tests/strategy_switch_worker_validation.mjs, and runs Node syntax checks, but the new instructions stop after Python unittest discovery. Contributors following this section can miss failures that the Validate strategy switch web assets CI step will reject, especially because unittest discovery will not execute the .mjs test.
Useful? React with 👍 / 👎.
Summary
Tests