Skip to content

Align contributing checks with CI#39

Merged
Pigbibi merged 1 commit into
mainfrom
codex/contributing-checks-doc
Jun 9, 2026
Merged

Align contributing checks with CI#39
Pigbibi merged 1 commit into
mainfrom
codex/contributing-checks-doc

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • update CONTRIBUTING local verification commands to match the dependency-free CI path

Tests

  • python3 scripts/runtime_settings.py validate
  • python3 -m unittest discover -s tests -v
  • node --experimental-default-type=module tests/strategy_switch_worker_validation.mjs
  • git diff --check

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8a02e766d9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CONTRIBUTING.md
git diff --check
python -m pytest -q
python3 scripts/runtime_settings.py validate
python3 -m unittest discover -s tests -v

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include web asset validation in local checks

For changes under web/strategy-switch-console, this documented local test set still does not match CI: .github/workflows/validate.yml runs sync_strategy_switch_page_asset.py, checks generated asset diffs/JQ, executes tests/strategy_switch_worker_validation.mjs, and runs Node syntax checks, but the new instructions stop after Python unittest discovery. Contributors following this section can miss failures that the Validate strategy switch web assets CI step will reject, especially because unittest discovery will not execute the .mjs test.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit 87edd66 into main Jun 9, 2026
2 checks passed
@Pigbibi Pigbibi deleted the codex/contributing-checks-doc branch June 9, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant