Skip to content

Clarify pending reserved cash summary#43

Merged
Pigbibi merged 1 commit into
mainfrom
codex/reserve-summary-pending-state
Jun 9, 2026
Merged

Clarify pending reserved cash summary#43
Pigbibi merged 1 commit into
mainfrom
codex/reserve-summary-pending-state

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • split the summary into current vs pending reserved-cash rows
  • stop showing example numbers as input placeholders so they are not mistaken for live values
  • avoid repeating the selected strategy when it matches the current strategy
  • keep reserve-only current state entries even when no strategy profile is readable

Tests

  • node --experimental-default-type=module tests/strategy_switch_worker_validation.mjs
  • python3 -m pytest tests/test_runtime_settings.py -q
  • node --check --input-type=module < web/strategy-switch-console/worker.js
  • node --check --input-type=module < web/strategy-switch-console/page_asset.js
  • node --check --input-type=module < web/strategy-switch-console/strategy_profiles_asset.js
  • sed -n '/<script>/,/</script>/p' web/strategy-switch-console/index.html | sed '1d;' | node --check --input-type=commonjs
  • jq empty web/strategy-switch-console/account-options.example.json web/strategy-switch-console/strategy-profiles.example.json
  • git diff --check

@Pigbibi Pigbibi merged commit b44f302 into main Jun 9, 2026
2 checks passed
@Pigbibi Pigbibi deleted the codex/reserve-summary-pending-state branch June 9, 2026 19:21

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 39a13afa88

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

variable_scope: "repository",
};
}
if (Object.keys(serviceTargetReservedCashPayload).length) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Continue resolving the profile when service targets only carry cash

When a matching CLOUD_RUN_SERVICE_TARGETS_JSON entry has reserved-cash fields but no strategy_profile, this early return stops the existing fallback reads from RUNTIME_TARGET_JSON and STRATEGY_PROFILE. In that mixed configuration the UI now reports the current strategy as not read (and may fall back to the account default) even though a lower-priority profile is still available; the reserve-only result should be merged only after those profile sources have been checked.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant